Uploaded image for project: 'Build Info'
  1. Build Info
  2. BI-111

Release staging does not respect existing line endings when rewriting pom

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Normal
    • Resolution: Fixed
    • Affects Version/s: 1.4.2
    • Fix Version/s: 2.0.4
    • Component/s: Extractor
    • Labels:
      None

      Description

      See https://github.com/cbeams/spring-project-maven/commit/704a0736d808cf3a834978f71533ee6755b5a15c

      original file had LF-endings; after release staging and publication, now CRLF.

        Attachments

          Activity

          Hide
          noam.tenne Noam Y. Tenne (Inactive) added a comment -

          This is an issue with the Maven build info extractor module.

          Show
          noam.tenne Noam Y. Tenne (Inactive) added a comment - This is an issue with the Maven build info extractor module.
          Hide
          noam.tenne Noam Y. Tenne (Inactive) added a comment -

          Also added EOL preservation to the Gradle properties transformer

          Show
          noam.tenne Noam Y. Tenne (Inactive) added a comment - Also added EOL preservation to the Gradle properties transformer
          Hide
          noam.tenne Noam Y. Tenne (Inactive) added a comment -

          Updated all the build server plugins to depend on the new snapshot.

          Show
          noam.tenne Noam Y. Tenne (Inactive) added a comment - Updated all the build server plugins to depend on the new snapshot.
          Hide
          csbeams Chris Beams added a comment -

          That's great, Noam - thank you!

          Any word on BI-111 (<scm> sections getting overwritten)?

          Cheers,

          Chris

          Show
          csbeams Chris Beams added a comment - That's great, Noam - thank you! Any word on BI-111 ( <scm> sections getting overwritten)? Cheers, Chris
          Hide
          noam.tenne Noam Y. Tenne (Inactive) added a comment - - edited

          It's on its way.

          Show
          noam.tenne Noam Y. Tenne (Inactive) added a comment - - edited It's on its way.
          Hide
          csbeams Chris Beams added a comment -

          Thanks, Noam. Just installed the snapshot along with the fix for BAP-94 and unix line endings are preserved as expected.

          Show
          csbeams Chris Beams added a comment - Thanks, Noam. Just installed the snapshot along with the fix for BAP-94 and unix line endings are preserved as expected.

            People

            • Assignee:
              noam.tenne Noam Y. Tenne (Inactive)
              Reporter:
              csbeams Chris Beams
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: