Uploaded image for project: 'Artifactory Binary Repository'
  1. Artifactory Binary Repository
  2. RTFACT-12694

Nuget - correct implementation of the $top query param

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: 4.13.2, 4.14.1
    • Fix Version/s: 4.14.2
    • Component/s: NuGet
    • Labels:
      None

      Description

      Artifactory currently sends back the $skip link on queries that have the $top param - this is not inline with with how the gallery handles $top queries and confuses the client.

      For example, if the client sends a first request with $top=30, and we give it back a next page link with $skip=80, we lose 50 results beacuse the client follows the pagination link instead of using its own logic for pagination (which is skipping 30 results at a time in correspondence to the $top value).

      To reproduce, use the attached script on https://www.jfrog.com/jira/browse/RTFACT-12379 to upload some versions and use this command:

      nuget.exe list -allversions -Source http://localhost:8080/artifactory/api/nuget/nuget-local -verbosity detailed

      On mac:
      mono --runtime=v4.0.30319 path/to/nuget.exe list -allversions -Source http://localhost:8080/artifactory/api/nuget/nuget-local -verbosity detailed

      See that the first request asks for $top=30 and contains a link to the next page with $skip=80, effectively skipping 50 results

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                shayy Shay Yaakov (Inactive)
                Reporter:
                uriahl Uriah Levy
              • Votes:
                3 Vote for this issue
                Watchers:
                6 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved: