Uploaded image for project: 'Artifactory Binary Repository'
  1. Artifactory Binary Repository
  2. RTFACT-13314

Deploying two builds with retention policy configured that need to remove the same build can cause a race condition

    Details

    • Type: Bug
    • Status: Open
    • Priority: High
    • Resolution: Unresolved
    • Affects Version/s: 4.9.0
    • Fix Version/s: None
    • Component/s: Build System
    • Labels:
      None

      Description

      Scenario: Two builds are deploying simultaneously. Both the builds has the retention policy configured. Those builds need to remove the same build (for example the same build name). This can cause a race condition that throws NPE when trying to remove a build that already was removed.

      2017-01-05 17:21:20,792 [http-nio-9091-exec-1] [INFO ] (o.a.a.b.BuildAddonImpl:279) Removing build 'Maven' #'5221'
      2017-01-05 17:21:20,793 [http-nio-9091-exec-1] [DEBUG] (o.a.b.BuildServiceImpl:262) Starting to remove build 'Maven' #5221
      2017-01-05 17:21:20,799 [http-nio-9091-exec-1] [DEBUG] (o.a.b.BuildServiceImpl:281) Starting to remove the artifacts of build 'Maven' #5221
      2017-01-05 17:21:24,302 [http-nio-9091-exec-1] [DEBUG] (o.a.b.BuildServiceImpl:290) Finished removing the artifacts of build 'Maven' #5221
      2017-01-05 17:21:24,304 [http-nio-9091-exec-1] [DEBUG] (o.a.b.BuildServiceImpl:273) Finished removing build 'Maven' #5221
      2017-01-05 17:21:24,307 [http-nio-9091-exec-9] [DEBUG] (o.a.b.BuildServiceImpl:273) Finished removing build 'Maven' #5222
      2017-01-05 17:21:24,307 [http-nio-9091-exec-9] [INFO ] (o.a.a.b.BuildAddonImpl:279) Removing build 'Maven' #'5221'
      2017-01-05 17:21:24,308 [http-nio-9091-exec-9] [DEBUG] (o.a.b.BuildServiceImpl:262) Starting to remove build 'Maven' #5221
      2017-01-05 17:21:24,308 [http-nio-9091-exec-9] [DEBUG] (o.a.b.BuildServiceImpl:281) Starting to remove the artifacts of build 'Maven' #5221
      2017-01-05 17:21:33,689 [http-nio-9091-exec-9] [ERROR] (o.a.a.b.BuildAddonImpl:283) Deleting build Maven #5221failed: null
      
      

        Attachments

          Activity

            People

            • Assignee:
              gidis Gidi Shabat
              Reporter:
              alexeiv Alexei Vainshtein
            • Votes:
              3 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated: