Uploaded image for project: 'Artifactory Binary Repository'
  1. Artifactory Binary Repository
  2. RTFACT-14863

GroovyRunnerImpl#getScripts should ignore the existence of the legacy reloadPlugins.groovy plugin

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.10.0
    • Component/s: Plugins
    • Labels:
      None

      Description

      The existence of the reloadPlugins.groovy plugin in the plugins dir causes Artifactory to reload all the plugins in an endless loop. The reason being the reloadPlugins.groovy file is never actually loaded due to a deliberate check in the code on versions 5.x. This causes the actual list of loaded scripts to always have a different size than the list of plugins in the 'plugins' dir, tricking artifactory to think it should reload the plugins every time the ScriptReloader thread wakes up.

      See GroovyRunnerImpl#getScripts

      Except being an annoyance, some plugins can behave really badly if they are reloaded repeatedly. This should be handled with high priority..

      The overall problem is not just the reloadPlugins plugin, the same situation would happen if a plugin (any plugin) fails to load and the groovy file is kept in the plugins dir.

        Attachments

          Activity

            People

            • Assignee:
              romang Roman Gurevitch (Inactive)
              Reporter:
              uriahl Uriah Levy
              Assigned QA:
              Saffi Hartal (Inactive)
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: