Uploaded image for project: 'Artifactory Binary Repository'
  1. Artifactory Binary Repository
  2. RTFACT-19278

"close transaction" is not handled properly when 2 requests are sent for the same transaction

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Done
    • Resolution: Done
    • Affects Version/s: None
    • Fix Version/s: 7.6.0
    • Component/s: None
    • Labels:
      None
    • Severity:
      Critical

      Description

      The issue is discovered in distribution automation tests where "close transaction" api called twice by distribution. 

      artifactory response for the first request is 200 and for the second request is 400

      see bellow request.log for bundle name: 1559032098146/1

      20190528082826|225|REQUEST|10.24.44.15|token:jfds@01dbwbnw4ps6m005ggba761pkk|POST|/api/release/bundle/transaction/close/_intransit/BD-1559032098146/1|HTTP/1.1|200|0 20190528082826|115|REQUEST|10.24.44.15|token:jfds@01dbwbnw4ps6m005ggba761pkk|POST|/api/release/bundle/transaction/close/_intransit/BD-1559032098146/1|HTTP/1.1|400|0
      

      artifactory returns with the following error message to distribution:

      "Could not find artifact maven-1559031761998/org/pom/test/multi1/1.1/multi1-1.1.jar"

      see bellow artifactory.log on edge3:

       

      2019-05-28 08:28:25,237 [http-nio-8081-exec-10] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.1/multi1-1.1.jar' Content-Length: 0
      2019-05-28 08:28:25,424 [http-nio-8081-exec-6] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.1/multi1-1.1-sources.jar' Content-Length: 0
      2019-05-28 08:28:25,569 [http-nio-8081-exec-4] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.2/multi1-1.2-tests.jar' Content-Length: 0
      2019-05-28 08:28:25,756 [http-nio-8081-exec-5] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.1/multi1-1.1-tests.jar' Content-Length: 0
      2019-05-28 08:28:26,069 [http-nio-8081-exec-3] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.2/multi1-1.2-sources.jar' Content-Length: 0
      2019-05-28 08:28:26,229 [http-nio-8081-exec-2] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.2/multi1-1.2.jar' Content-Length: 0
      2019-05-28 08:28:26,234 [http-nio-8081-exec-7] [INFO ] (o.a.e.UploadServiceImpl:401) - Deploy to '_intransit:BD-1559032098146/1/nuget-1559031761998/sample-nuget1-10.1.10.0.nupkg' Content-Length: 0
      2019-05-28 08:28:26,690 [http-nio-8081-exec-10] [ERROR] (o.a.r.s.RepositoryServiceImpl:2192) - Could not locate artifact '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.2/multi1-1.2.jar' (Nothing to delete).
      2019-05-28 08:28:26,693 [http-nio-8081-exec-10] [ERROR] (o.a.a.r.b.ReleaseBundleAddonImpl:856) - Could not find artifact _intransit/BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.1/multi1-1.1.jar
      2019-05-28 08:28:26,694 [http-nio-8081-exec-10] [WARN ] (o.a.s.f.l.SessionLockEntry:132) - Mutable item '_intransit:BD-1559032098146/1/maven-1559031761998/org/pom/test/multi1/1.2/multi1-1.2.jar' has local modifications that will be discarded.
      

      the files from _intransit repo are transferred successfully to the target path but since exception is thrown the bundle is not created.

      see attached sc.

       

        Attachments

        1. bundle_in_intransit.png
          bundle_in_intransit.png
          202 kB
        2. missing_bundle.png
          missing_bundle.png
          71 kB
        3. target repo.png
          target repo.png
          174 kB

          Activity

              People

              Assignee:
              elis Eli Skoran
              Reporter:
              aviva Aviv Anidjar
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: