Details
-
Type:
Improvement
-
Status: Open
-
Priority:
Normal
-
Resolution: Unresolved
-
Affects Version/s: 6.13.1
-
Fix Version/s: None
-
Component/s: None
-
Labels:None
Description
In a immutable infrastructure:
https://www.digitalocean.com/community/tutorials/what-is-immutable-infrastructure
If Artifactory is deployed, the VM's are recycled which makes the IP's dynamic and change it everytime a new VM is deployed.
This causes the remote_stats table present in the database coupled with the Artifactory be populated with IP's which are irrelevant.
The structure(Columns of the remote_stats) table has the following values:
node_id | origin | download_count | last_downloaded | last_downloaded_by | path
The Origin column in the above remote_stats table is populated with the IP address of the Artifactory instance which becomes not useful since the IP's are dynamic in a immutable infrastructure.
Since Artifactory isn't using Tomcat's RemoteIpValve:
https://tomcat.apache.org/tomcat-8.5-doc/api/org/apache/catalina/valves/RemoteIpValve.html
We cannot use the X-Forwareded-For requests and overwrite the origin value in the remote_stats table.
Instead of the having the IP address of the VM's as the origin values in the remote_stats table, if we have the more static values like either the servername or the License hash's as the Origin value will be more relevant and so that we do not lose on the historical data on the remote_stats table in the database for the download counts.