Uploaded image for project: 'Artifactory Binary Repository'
  1. Artifactory Binary Repository
  2. RTFACT-20676

Manual deploy of "invalid" NPM package

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Open
    • Priority: Normal
    • Resolution: Unresolved
    • Affects Version/s: 7.0.0-beta
    • Fix Version/s: None
    • Component/s: NPM
    • Labels:
      None
    • Environment:

      jfrog-artifactory-pro-linux-7.0.0-m507.tar.gz on Debian 9, installed as a service

      Description

      Artifactory let me manually deploy any TAR.GZ file as an NPM artifact (even if it does not contain a package.json file).

      When deploying, I checked the option "Deploy According To Layout" and gave the layout tokens "orgPath", "module" and "baseRev".

      After this, package never gets indexed by MDS and never shows up in the Package search.

      Artifactory logs show:

      2019-11-20T12:47:52.361Z [jfrt ] [INFO ] [4dcd5fd4b2211f54] [o.a.e.UploadServiceImpl:399 ] [http-nio-8082-exec-3] - Deploy to 'npm-repo:com.jfrog/jfrog-mc-docker-compose/jfrog-mc-docker-compose-4.0.0-m216.tgz' Content-Length: 5236778
      2019-11-20T12:47:52.535Z [jfrt ] [WARN ] [81a47af4632fc26e] [.n.r.NpmPackageWorkContext:133] [art-exec-16 ] - Npm package name is blank
      2019-11-20T12:47:52.536Z [jfrt ] [WARN ] [81a47af4632fc26e] [n.NpmPackageMetadataIndexer:60] [art-exec-16 ] - Could not find the package name on the context, skipping indexing.
      

      Expected behaviour:

      • Either reject the artifact if it does not contain a valid package.json
      • Or index the package using the metadata provided by the layout tokens

        Attachments

          Activity

            People

            Assignee:
            Unassigned
            Reporter:
            Cyrilc Cyril Chene
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: