Uploaded image for project: 'Artifactory Binary Repository'
  1. Artifactory Binary Repository
  2. RTFACT-21994

Artifactory should support Windows line endings (CR LF) on metadata calculation

    XMLWordPrintable

    Details

    • Type: Improvement
    • Status: Done
    • Priority: 4 - Normal
    • Resolution: Done
    • Affects Version/s: 6.17.0, 6.19.1
    • Fix Version/s: 7.12.3
    • Component/s: None
    • Labels:
      None
    • Release Notes:
      No

      Description

      Metadata calculation is failing when YAML file contains Windows line endings (CR LF).
      Example:
      Helm chart kafka-router-1.0.2.tgz was not being indexed in index.yaml and causing below errors in Artifactory logs

      2020-04-27 14:32:56,225 [art-exec-16949363] [ERROR] (o.j.r.h.HelmMetadataExtractor:72) - Could not extract metadata from chart kafka-router-1.0.2.tgz 

      Upon investigation, we determined that some of the files in kafka-router-1.0.2.tgz had Windows (CR LF) line endings instead of Unix (LF) line endings.

      Specifically:

      kafka-router-1.0.2.tgz has templates/configmap.yaml with Windows line endings (CR LF). whereas kafka-router-1.0.3.tgz has templates/configmap.yaml with Unix line endings (LF)

      The same was true of other files such as values.yaml, templates/deployment.yaml and .helmignore (though Chart.yaml did have LF line endings).

      In the Web UI tree browser, kafka-router-1.0.2.tgz appears correctly alongside other versions with Unix line endings such as chart kafka-router-1.0.1.tgz and chart kafka-router-1.0.3.tgz, however, when you look at the Chart Info it is blank. Indeed, when you look at the Chart Info for kafka-router-1.0.3.tgz and then move to chart kafka-router-1.0.2.tgz, the Chart Info for chart kafka-router-1.0.3.tgz is still displayed. Each time you attempt to load the Chart Info for chart kafka-router-1.0.2.tgz, the following Error 500 is generated and can be seen in the Chrome Developer Console:

       

      /artifactory/ui/views/helm:1 Failed to load resource: the server responded with a status of 500 (Internal Server Error)
      

      Customer ASK:
      1) Artifactory should support Windows line endings.
      2) If Helm Chart information cannot be displayed, instead of a hidden Error 500 that won't be seen by users, could more information be provided? It feels wrong that Chart Info for another chart is still displayed when in actual fact an error has occurred.

        Attachments

          Activity

            People

            Assignee:
            volodymyrs Volodymyr Shulga [EXT]
            Reporter:
            sankark Sankar Kumar
            Votes:
            1 Vote for this issue
            Watchers:
            5 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved:

                Sync Status

                Connection: RTFACT Sync
                RTMID-21994 -
                SYNCHRONIZED
                • Last Sync Date: