[BAP-353] Availablity for bamboo 5.12.x Created: 20/Jun/16  Updated: 12/Jul/16  Resolved: 10/Jul/16

Status: Resolved
Project: Bamboo Artifactory Plug-in
Component/s: None
Affects Version/s: 1.10.2
Fix Version/s: 1.11.0

Type: Improvement Priority: Minor
Reporter: Catherine Aldrich Assignee: Tamir Hadad
Resolution: Fixed Votes: 0
Labels: None

Issue Links:
Trigger
triggered BAP-352 Error when releasing artifact with Ba... Resolved

 Description   

When will this be available for Bamboo 5.12.xx? We cannot upgrade to Bamboo 5.11.xx (from Bamboo 5.10.1.1) due to an issue in 5.11 that is fixed in 5.12.xx, but we can't upgrade until there is a compatible bamboo artifactory plugin.

Thanks!



 Comments   
Comment by Eyal Ben Moshe (Inactive) [ 20/Jun/16 ]

Hi Catherine,
We are not aware of any compatibility issue between the latest release of the plugin and Bamboo 5.12.x.

Comment by Catherine Aldrich [ 21/Jun/16 ]

I just did a test upgrade to bamboo 5.12.2.1, and in the plugin section, it specifies that the plugin (1.10.3) is incompatible. This is a critical plugin for our developers, so I'm hesitant to upgrade production.

Comment by Catherine Aldrich [ 23/Jun/16 ]

Are there any plans to test to make sure it is compatible or update the compatibility level so we don't get the message that it is incompatible?

Comment by Eyal Ben Moshe (Inactive) [ 23/Jun/16 ]

Sure Catherine. We'll test this soon and update the compatibility accordingly. We'll also add a note on this ticket when done.

Comment by Catherine Aldrich [ 07/Jul/16 ]

I received an e-mail that a new version of Artifactory for Bamboo has been released - Version 1.11.0 is now available in the Atlassian Marketplace - and is compatible with bamboo 5.12.x.

In testing, it is not working. The first time I started bamboo, it enabled 23 of 26 modules. It would not enable the rest. I tried then disabling and renabling the plugin, and it would not enable due to errors. I shutdown and restarted bamboo, and it wouldn't enable. I will attach the catalina.out log if I can.

Comment by Catherine Aldrich [ 07/Jul/16 ]

How do I attach a log file? Here are some of the entries:

2016-07-07 07:58:14,208 INFO [FelixStartLevel] [EventAdminDispatcher] EventAdmin package not found; no Blueprint lifecycle events will be published
2016-07-07 07:58:14,893 WARN [localhost-startStop-1] [NoOpModuleDescriptor] Plugin Bamboo Artifactory Plugin (org.jfrog.bamboo.bamboo-artifactory-plugin) still uses plugin point builder2TaskConverter which is obsolete. Please contact plugin vendor JFrog Ltd. to update the plugin.
2016-07-07 07:58:14,893 WARN [localhost-startStop-1] [NoOpModuleDescriptor] Plugin Bamboo Artifactory Plugin (org.jfrog.bamboo.bamboo-artifactory-plugin) still uses plugin point builder2TaskConverter which is obsolete. Please contact plugin vendor JFrog Ltd. to update the plugin.
2016-07-07 07:58:14,893 WARN [localhost-startStop-1] [NoOpModuleDescriptor] Plugin Bamboo Artifactory Plugin (org.jfrog.bamboo.bamboo-artifactory-plugin) still uses plugin point builder2TaskConverter which is obsolete. Please contact plugin vendor JFrog Ltd. to update the plugin.
2
2016-07-07 07:58:14,910 WARN [localhost-startStop-1] [TaskModuleDescriptorImpl] Category definition for Task Type artifactoryGenericResolveTask of plugin org.jfrog.bamboo.bamboo-artifactory-plugin is not valid. No such category as: [resolve]

and later on

2016-07-07 07:58:31,425 ERROR [localhost-startStop-1] [DefaultPluginManager] There was an error loading the descriptor 'Artifactory Maven Builder Converter' of plugin 'org.jfrog.bamboo.bamboo-artifactory-plugin:1.11.0'. Disabling.
java.lang.IllegalStateException: This plugin module can not be enabled
at com.atlassian.bamboo.plugin.descriptor.NoOpModuleDescriptor.enabled(NoOpModuleDescriptor.java:39)
at com.atlassian.plugin.manager.DefaultPluginManager.notifyModuleEnabled(DefaultPluginManager.java:1883)
at com.atlassian.plugin.manager.DefaultPluginManager.enableConfiguredPluginModule(DefaultPluginManager.java:1631)
at com.atlassian.plugin.manager.DefaultPluginManager.enableConfiguredPluginModules(DefaultPluginManager.java:1608)
at com.atlassian.plugin.manager.DefaultPluginManager.enableDependentPlugins(DefaultPluginManager.java:1094)
at com.atlassian.plugin.manager.DefaultPluginManager.addPlugins(DefaultPluginManager.java:1055)
at com.atlassian.bamboo.plugin.BambooPluginManager.addPlugins(BambooPluginManager.java:90)
at com.atlassian.plugin.manager.DefaultPluginManager.earlyStartup(DefaultPluginManager.java:474)
at com.atlassian.plugin.manager.DefaultPluginManager.init(DefaultPluginManager.java:404)
at com.atlassian.bamboo.container.BambooContainer.init(BambooContainer.java:215)
at com.atlassian.bamboo.container.BambooContainer.initialise(BambooContainer.java:196)
at com.atlassian.bamboo.upgrade.UpgradeLauncher.initialiseBambooContainer(UpgradeLauncher.java:184)
at com.atlassian.bamboo.upgrade.UpgradeLauncher.upgradeAndStartBamboo(UpgradeLauncher.java:97)
at com.atlassian.bamboo.upgrade.UpgradeLauncher.contextInitialized(UpgradeLauncher.java:41)
at org.apache.catalina.core.StandardContext.listenerStart(StandardContext.java:4812)
at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5255)
at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:147)
at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1408)
at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1398)
at java.util.concurrent.FutureTask.run(FutureTask.java:266)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at java.lang.Thread.run(Thread.java:745)

Comment by Tamir Hadad [ 07/Jul/16 ]

Hi Catherine ,
First, thanks for your feedback.
Those three modules which are disabled are deprecated since Bamboo 5.11.
We will remove them in our next version.
In the meantime, don't try to enable those modules.
If you can please try to enable the plugin more than once and make sure all the 23 modules are enabled.
Thanks,
Tamir

Comment by Catherine Aldrich [ 07/Jul/16 ]

Thank you for the response.

The problem is that now it won't enable the plugin at all. I get an error that there is a problem with it. I have restarted bamboo, rebooted the server, removed the plugin (removed the .jar file) and restarted, then added it back and restarted - nothing works. Something must be blocking enabling this plugin. What else can I clear - is my only resort rebuilding from scratch? Luckily this is a test upgrade, but I don't want the real upgrade to encounter issues.

Comment by Eyal Ben Moshe (Inactive) [ 07/Jul/16 ]

Catherine,
We managed to reproduce the issue you reported. It seems that after attempting to enable or disable the deprecated add-ons, the plugin becomes disabled. If you don't attempt to do so, all is working properly.
We fixed the issue by removing the deprecated add-ons. Please try out the below snapshot. If all works well for you, we will issue a new release.
Downlink link for the fix:
https://oss.jfrog.org/oss-snapshot-local/org/jfrog/bamboo/bamboo-artifactory-plugin/1.11.x-SNAPSHOT/bamboo-artifactory-plugin-1.11.x-SNAPSHOT.jar

Comment by Catherine Aldrich [ 07/Jul/16 ]

I replaced the existing plugin with this snapshot, restarted the test server, and it now shows as enabled with 23 modules, as expected. So, it works. Thanks for the quick response. Once the official release is available, I'll continue my testing and then hopefully upgrade our production system.

Comment by Catherine Aldrich [ 12/Jul/16 ]

Just an FYI - bamboo came out with 5.12.3.1, and when test upgrading, it says this is not compatible. I enabled it and it didn't have a problem enabling (usually if it's not compatible, bamboo either won't start or we can't enable the plugin).

Comment by Eyal Ben Moshe (Inactive) [ 12/Jul/16 ]

Thanks Catherine.

Generated at Tue May 21 13:32:21 UTC 2019 using JIRA 7.6.3#76005-sha1:8a4e38d34af948780dbf52044e7aafb13a7cae58.