[HAP-1151] Plugin needs concurrent data structure Created: 14/Feb/19  Updated: 31/Mar/19  Resolved: 31/Mar/19

Status: Resolved
Project: Jenkins Artifactory Plug-in
Component/s: None
Affects Version/s: 3.2.1
Fix Version/s: 3.2.2

Type: Bug Priority: High
Reporter: David Xu Assignee: Eyal Ben Moshe
Resolution: Fixed Votes: 2
Labels: None


 Description   

After looking at the source code for the Jenkins plugin, it appears that a new ArrayList() is still being used instead of a concurrent safe data structure. This appears to be causing the exceptions on our build systems

Errors thrown prior to plugin crashing

[Pipeline] End of Pipeline
an exception which occurred:
in field java.util.Collections$SynchronizedCollection.c
in object java.util.Collections$SynchronizedList@b960033e
in field org.jfrog.hudson.pipeline.common.types.buildInfo.BuildInfo.modules
in object org.jfrog.hudson.pipeline.common.types.buildInfo.BuildInfo@69af4dab
in field groovy.lang.Closure.delegate
in object org.jenkinsci.plugins.workflow.cps.CpsClosure2@776996f4
in field groovy.lang.Closure.delegate
in object org.jenkinsci.plugins.workflow.cps.CpsClosure2@24128ba
in field org.jenkinsci.plugins.workflow.cps.CpsThreadGroup.closures
in object org.jenkinsci.plugins.workflow.cps.CpsThreadGroup@c4803fe
in object org.jenkinsci.plugins.workflow.cps.CpsThreadGroup@c4803fe
Caused: java.util.ConcurrentModificationException


 Comments   
Comment by Joshua Perlow [ 20/Feb/19 ]

Why is this labelled as an improvement instead of as a bug fix? This request is a result of a java.util.ConcurrentModificationException.

Comment by Anthony [ 21/Feb/19 ]

Eyal Ben Moshe David Xu

What is the response time on the tickets?  This was submitted a week ago with no comments, response, resolution or possible ETA

Comment by Eyal Ben Moshe [ 24/Feb/19 ]

Thank you for reporting this issue!

We merged the following pull request to fix the issue:

https://github.com/jfrog/jenkins-artifactory-plugin/pull/117

Here's a download link to a snapshot version which includes the fix:

https://repo.jenkins-ci.org/snapshots/org/jenkins-ci/plugins/artifactory/3.2.x-SNAPSHOT/artifactory-3.2.x-20190224.155622-3.hpi

We'd appreciate your feedback for it. Please let us know if this resolves the issue.

Thanks

Comment by Joshua Perlow [ 01/Mar/19 ]

Although we were not able to reproduce the error in our test environment, our team is satisfied with our test results from the new plugin and would like to request a release version.

Generated at Sun Jul 21 04:48:40 UTC 2019 using JIRA 7.6.3#76005-sha1:8a4e38d34af948780dbf52044e7aafb13a7cae58.