[RTFACT-15016] Artifactory is not returning Cache-Control header for -SNAPSHOT/sha1/.jar artifacts Created: 28/Sep/17 Updated: 07/Sep/18 Resolved: 21/Aug/18 |
|
Status: | Resolved |
Project: | Artifactory Binary Repository |
Component/s: | None |
Affects Version/s: | 5.5.1 |
Fix Version/s: | 6.4.0 |
Type: | Bug | Priority: | Normal |
Reporter: | Guy Cohen | Assignee: | Dudi Morad (Inactive) |
Resolution: | Fixed | Votes: | 0 |
Labels: | None | ||
Remaining Estimate: | 3 days, 1 hour | ||
Time Spent: | 1 day, 7 hours | ||
Original Estimate: | 1 week |
Estimated Resolution Quarter: | Q3-18 |
Support Tickets: | |
Product Comments: | ETA is Q2-18. |
Sprint: | Leap 34 |
Support Rep(s): |
Guy Cohen
|
Reviewer: |
Gal Ben Ami
|
Description |
This appears to be a regression for curl -vvv -X GET http://localhost:8080/artifactory/libs-snapshot-local/org/jfrog/test/multi/3.8-SNAPSHOT/maven-metadata.xml -uadmin:password
Here is the response without Cache-Control header (for '-SNAPSHOT' suffix)
Another response without Cache-Control header
|
Comments |
Comment by Atlassian Build Team [ 05/Oct/17 ] |
The issues we have are: Artifactory does NOT send response header "Cache-control: no-store" for *-SNAPSHOT/maven-metadata.xml.sha1. But it SHOULD. Artifactory does NOT send "Cache-Control: no-store" for *-SNAPSHOT.jar. But it SHOULD. Artifactory does NOT send "Cache-control: no-store" for ?trace requests, but it SHOULD. For snapshot with timestamps in it's file name, e.g "multi-3.8-20170222.201153-11.pom", I think it is probably OK to NOT send the no-store header. Also it is ok to NOT send no-store header for non-snapshot versions, e.g. "guava-18.0.jar " |
Comment by Atlassian Build Team [ 05/Oct/17 ] |
I mean it is correct to NOT send "no-store" for timestamped artifacts and non-snapshot artifacts. |
Comment by Atlassian Build Team [ 05/Oct/17 ] |
Another issue: artifactory does not send no-store header for metadata of npm packages, but it SHOULD. |
Comment by Manoj Tuguru [ 25/Jan/18 ] |
The same behavior occurs for the debian repositories as well:
|
Comment by Atlassian Build Team [ 21/Feb/18 ] |
Another 2 files that should not be cached but artifactory does not send "Cache-control: no-store" header. https://myArtifactory.com/myDebianRepo/dists/xenial/Release https://myArtifactory.com/myDebianRepo/dists/xenial/Release.gpg |
Comment by Atlassian Build Team [ 08/Mar/18 ] |
Another case
https://myArtifactory.com/myDebianRepo/dists/xenial/PC1/binary-amd64/Packages.gz(.sha1|.md5)
|
Comment by Atlassian Build Team [ 23/Mar/18 ] |
Another case
https://myArtifactory.com/myYumRepo/repodata.xml(.asc|.key)
|
Comment by Atlassian Build Team [ 27/Mar/18 ] |
Can we also stop caching trace requests? E.g.
http://myartifactory/maven-local/com/mycompany/myartifact/1.0.0/myartifact-1.0.0.pom?trace
|
Comment by Atlassian Build Team [ 28/May/18 ] |
Hi there,
We are on Artifactory 5.10.3. I can confirm that maven/apt/yum metadata has been fixed. However, npm/pypi and trace requests are still not fixed yet. E.g. https://myinstance/myinstance/api/npm/npm-repo/package https://myinstance/myinstance/pypi/simple/acorn/ https://myinstance/myinstance/maven/com/test/1.0/test-1.0.jar?trace |