[RTFACT-17965] Not all admins get informed when backup fails Created: 04/Dec/18  Updated: 05/Dec/18

Status: Open
Project: Artifactory Binary Repository
Component/s: None
Affects Version/s: 6.3.3
Fix Version/s: None

Type: Bug Priority: Normal
Reporter: Krzysztof Malinowski Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: None


 Description   

When backup task fails, Artifactory tries to notify administrators, but it gives up on first email that it cannot send, i.e.:

2018-12-04 08:11:52,440 [art-exec-2430] [ERROR] (o.a.b.BackupServiceImpl:276) - Error while notification of: 'backup-daily' errors.
org.artifactory.util.EmailException: Failed to send e-mail to name@company.com due to Invalid Addresses
        at org.artifactory.mail.MailServiceImpl.sendMail(MailServiceImpl.java:182)
        at org.artifactory.mail.MailServiceImpl.sendMail(MailServiceImpl.java:199)
        at org.artifactory.mail.MailServiceImpl.sendMail(MailServiceImpl.java:72)
        at org.artifactory.backup.BackupServiceImpl.sendBackupErrorMail(BackupServiceImpl.java:295)
        at org.artifactory.backup.BackupServiceImpl.lambda$sendBackupErrorNotification$0(BackupServiceImpl.java:274)
        at java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184)
        at java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:175)
        at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1374)
        at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
        at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
        at java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151)
        at java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174)
        at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
        at java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:418)
        at org.artifactory.backup.BackupServiceImpl.sendBackupErrorNotification(BackupServiceImpl.java:274)
        at sun.reflect.GeneratedMethodAccessor2909.invoke(Unknown Source)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:498)
        at org.springframework.aop.support.AopUtils.invokeJoinpointUsingReflection(AopUtils.java:317)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.invokeJoinpoint(ReflectiveMethodInvocation.java:190)
        at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:157)
        at org.artifactory.schedule.aop.TraceableMethodInvocation.proceed(TraceableMethodInvocation.java:58)
        at org.artifactory.schedule.aop.AsyncAdvice.doInvoke(AsyncAdvice.java:333)
        at org.artifactory.schedule.aop.AsyncAdvice.lambda$submit$2(AsyncAdvice.java:285)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at org.artifactory.concurrent.ArtifactoryRunnable.run(ArtifactoryRunnable.java:30)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:748)
Caused by: javax.mail.SendFailedException: Invalid Addresses
        at com.sun.mail.smtp.SMTPTransport.rcptTo(SMTPTransport.java:1862)
        at com.sun.mail.smtp.SMTPTransport.sendMessage(SMTPTransport.java:1118)
        at org.artifactory.mail.MailServiceImpl.sendMail(MailServiceImpl.java:179)
        ... 28 common frames omitted
Caused by: com.sun.mail.smtp.SMTPAddressFailedException: 550 5.1.1 <name@company.com>... User unknown

        at com.sun.mail.smtp.SMTPTransport.rcptTo(SMTPTransport.java:1715)
        ... 30 common frames omitted

No other administrator gets the email of failed task.

Expected result: Artifactory should attempt to notify every administrator.


Generated at Tue Sep 22 18:38:45 UTC 2020 using Jira 8.5.3#805003-sha1:b4933e02eaff29a49114274fe59e1f99d9d963d7.