[RTFACT-9992] The docker v1 to v2 migration process does not correctly log the ending Created: 29/Apr/16  Updated: 21/Feb/18  Resolved: 29/Jan/18

Status: Resolved
Project: Artifactory Binary Repository
Component/s: Docker, Logging
Affects Version/s: 4.7.4
Fix Version/s: None

Type: Improvement Priority: Minor
Reporter: Arturo Aparicio Assignee: Uriah Levy
Resolution: Won't Fix Votes: 0
Labels: None


The docker v1 to v2 migration process does not correctly log the ending. The message "Finished docker migration from '<docker-v1-repo-name>' to '<docker-v2-repo-name>'" appears before tagging is complete.

The logs end up looking like this:

2016-04-29 03:42:45,290 [art-exec-1] [INFO ] (o.j.r.d.v.m.DockerMigrator:83) - Finished docker migration from 'docker' to 'dockerv2'
2016-04-29 03:42:45,291 [pool-12-thread-1] [INFO ] (o.j.r.d.v.m.DockerMigrator:138) - Starting tag migration for 'busybo/latest/manifest.json'
2016-04-29 03:42:45,456 [pool-12-thread-1] [INFO ] (o.j.r.d.v.m.DockerMigrator:147) - Finished tag migration for 'busybo/latest/manifest.json'

This makes it hard to determine when the migration is complete. The ""Finished docker migration from..." should appear only at the end, when everything is complete.

To Reproduce

Simply perform the migration of a v1 docker repo to a v2 repo as explained in https://www.jfrog.com/confluence/display/RTF/Using+Docker+V1#UsingDockerV1-MigratingaV1repositorytoV2.

Comment by Uriah Levy [ 29/Jan/18 ]

This is indeed confusing. The reason this is happening is that the migration process is multi-threaded, so the ordering of the logging and tag/repo migration is non deterministic. Closing as a "won't fix" for now since this issue was deferred.

Generated at Tue Aug 11 15:22:31 UTC 2020 using Jira 8.5.3#805003-sha1:b4933e02eaff29a49114274fe59e1f99d9d963d7.